make this more dynamic #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure I can merge that. If you don't mind updating the setup bit in the readme that would be cool also. |
|
Sure thing. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since you said in another PR that you wanted to keep this repo as a non-PHP version I rewrote this to use a nice bit of Javascript to make it more dynamic. Now you just edit the config.json and it'll add in the services that have a URL and keep the others out.
It also uses bower for the vender/library files and creates minified versions of the assets.
If you want to build new versions of the files you'll need npm, node and bower installed then run
npm install && gruntto get everything going.