attach: always drop supplementary groups #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 9, 2018 18:01
Closes lxc#1704. Signed-off-by: Christian Brauner <[email protected]>
Closes lxc#2248. Signed-off-by: Christian Brauner <[email protected]>
hallyn
reviewed
Apr 10, 2018
| @@ -870,12 +870,12 @@ static int attach_child_main(struct attach_clone_payload *payload) | |||
| ret = lxc_switch_uid_gid(new_uid, new_gid); | |||
| if (ret < 0) | |||
| goto on_error; | |||
|
|
|||
| ret = lxc_setgroups(0, NULL); | |||
There was a problem hiding this comment.
Isn't that going to break users who are stuck in a deny_setgroups environment?
|
Hm, we can special case this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1704.
Signed-off-by: Christian Brauner [email protected]