Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): correct typos in README.md #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ptu14
Copy link

@ptu14 ptu14 commented Jan 12, 2025

Description

This PR fixes a typo in the Emscripten port documentation. Specifically, I corrected misspellings such as "Downlad" to "Download," "ope na" to "open a," and others. These changes improve the clarity and professionalism of the documentation.

No functional code changes introduced

Copy link
Member

@kisvegabor kisvegabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've just found one more things as I was reviewing it.

README.md Outdated
7. `emmake make -j4`
5. A file called `index.html` will be generated. Run this in your browser.
1. In any directory: `git clone --recursive https://github.com/lvgl/lv_web_emscripten.git`
1. `cd <path-to-emscripten>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. `cd <path-to-emscripten>`
1. `cd lv_web_emscripten`

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do the same thing with cd emsdk.
Additionally, I numbering in the first list to use "1." consistently.
I’ve amended the commit and force-pushed the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants