Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Keyring and Hub Request #71

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Fix: Keyring and Hub Request #71

merged 3 commits into from
Feb 21, 2025

Conversation

kozlov721
Copy link
Collaborator

Purpose

Fix for hanging keyring operations on certain systems.

Specification

  • Added timeout for retrieving API key from the keyring
  • Improved the requests state so the key can be changed dynamically
  • Improved error messages

@kozlov721 kozlov721 requested a review from a team as a code owner February 20, 2025 23:06
@kozlov721 kozlov721 requested review from klemen1999, tersekmatija and conorsim and removed request for a team February 20, 2025 23:06
@kozlov721 kozlov721 changed the title Fix/hub key Fix: Keyring and Hub Request Feb 20, 2025
Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment

@kozlov721 kozlov721 merged commit 04ef5fd into main Feb 21, 2025
1 check passed
@kozlov721 kozlov721 deleted the fix/hub-key branch February 21, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants