Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RVC2 and RVC3 migration to python3.10 #67

Merged
merged 18 commits into from
Feb 12, 2025
Merged

RVC2 and RVC3 migration to python3.10 #67

merged 18 commits into from
Feb 12, 2025

Conversation

kozlov721
Copy link
Collaborator

@kozlov721 kozlov721 commented Feb 7, 2025

Purpose

Makes it possible to migrate modelconverter and luxonis-ml packages to Python 3.10

Specification

  • Rewritten RVC2 and RVC3 dockerfiles so they can use python3.10 for running modelconverter but still use python3.8 to run mo and compile_tool
  • RVC3 conversion uses the pot command for quantization instead of the python API
    • To avoid version clashes

Dependencies & Potential Impact

  • We should wait at least one release before upgrading the packages to python 3.10 so we can be more confident the new images are stable

@kozlov721 kozlov721 requested a review from a team as a code owner February 7, 2025 15:02
@kozlov721 kozlov721 requested review from klemen1999, tersekmatija and conorsim and removed request for a team February 7, 2025 15:02
@kozlov721 kozlov721 force-pushed the docker/python-3.10 branch 2 times, most recently from 280b3ee to 7397b05 Compare February 11, 2025 03:43
@kozlov721 kozlov721 self-assigned this Feb 11, 2025
@kozlov721 kozlov721 added docker Changes related to docker images RVC2 Changes affecting RVC2 export RVC3 Changes affecting RVC3 export labels Feb 11, 2025
@kozlov721 kozlov721 merged commit 57b1be9 into main Feb 12, 2025
9 of 11 checks passed
@kozlov721 kozlov721 deleted the docker/python-3.10 branch February 12, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Changes related to docker images RVC2 Changes affecting RVC2 export RVC3 Changes affecting RVC3 export
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants