Added semgrep and some fixes (#74)

.github/workflows/semgrep.yaml

@@ -0,0 +1,65 @@
+name: Semgrep SAST Scan
+
+on:
+  pull_request:
+
+jobs:
+  semgrep:
+    # User definable name of this GitHub Actions job.
+    name: semgrep/ci
+    # If you are self-hosting, change the following `runs-on` value:
+    runs-on: ubuntu-latest
+    container:
+      # A Docker image with Semgrep installed. Do not change this.
+      image: returntocorp/semgrep
+    # Skip any PR created by dependabot to avoid permission issues:
+    if: (github.actor != 'dependabot[bot]')
+    permissions:
+      # required for all workflows
+      security-events: write
+      # only required for workflows in private repositories
+      actions: read
+      contents: read
+
+    steps:
+      # Fetch project source with GitHub Actions Checkout.
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Perform Semgrep Analysis
+      # @NOTE: This is the actual semgrep command to scan your code.
+      # Modify the --config option to 'r/all' to scan using all rules,
+      # or use multiple flags to specify particular rules, such as
+      # --config r/all --config custom/rules
+        run: semgrep scan -q --sarif --config auto --config "p/secrets" . > semgrep-results.sarif
+
+      - name: Pretty-Print SARIF Output
+        run: |
+          jq . semgrep-results.sarif > formatted-semgrep-results.sarif || echo "{}"
+          echo "Formatted SARIF Output (First 20 lines):"
+          head -n 20 formatted-semgrep-results.sarif || echo "{}"
+
+      - name: Validate JSON Output
+        run: |
+          if ! jq empty formatted-semgrep-results.sarif > /dev/null 2>&1; then
+            echo "⚠️ Semgrep output is not valid JSON. Skipping annotations."
+            exit 0
+          fi
+
+      - name: Add PR Annotations for Semgrep Findings
+        run: |
+          total_issues=$(jq '.runs[0].results | length' formatted-semgrep-results.sarif)
+          if [[ "$total_issues" -eq 0 ]]; then
+            echo "✅ No Semgrep issues found!"
+            exit 0
+          fi
+
+          jq -c '.runs[0].results[]' formatted-semgrep-results.sarif | while IFS= read -r issue; do
+            file=$(echo "$issue" | jq -r '.locations[0].physicalLocation.artifactLocation.uri')
+            line=$(echo "$issue" | jq -r '.locations[0].physicalLocation.region.startLine')
+            message=$(echo "$issue" | jq -r '.message.text')
+
+            if [[ -n "$file" && -n "$line" && -n "$message" ]]; then
+              echo "::error file=$file,line=$line,title=Semgrep Issue::${message}"
+            fi
+          done

modelconverter/packages/hailo/exporter.py

@@ -21,8 +21,8 @@
 
 @contextmanager
 def _replace_module(original, substitute):
-    original_module = importlib.import_module(original)
-    substitute_module = importlib.import_module(substitute)
+    original_module = importlib.import_module(original)  # nosemgrep
+    substitute_module = importlib.import_module(substitute)  # nosemgrep
 
     sys.modules[original] = substitute_module
     try:

modelconverter/packages/multistage_exporter.py

@@ -110,10 +110,21 @@ def _produce_calibration_data(self, exporter: Exporter) -> None:
                         for out_name in output_dirs
                     }
 
-                    # TODO: safe exec
                     local_scope = {}
+                    safe_globals = {"__builtins__": {}}
+
+                    try:
+                        exec(  # nosemgrep
+                            script, safe_globals, local_scope
+                        )
+                    except Exception as e:
+                        raise RuntimeError(f"Error executing script: {e}")
+
+                    if "run_script" not in local_scope:
+                        raise RuntimeError(
+                            "Error: `run_script` function not found in script."
+                        )
 
-                    exec(script, globals(), local_scope)
                     run_script = local_scope["run_script"]
                     arr = run_script(outputs)
                     np.save(dest / f"{i}.npy", arr)

modelconverter/utils/nn_archive.py

@@ -47,8 +47,21 @@ def process_nn_archive(
     elif tarfile.is_tarfile(path):
         if untar_path.suffix == ".tar":
             untar_path = MISC_DIR / untar_path.stem
-        with tarfile.open(path) as tar:
-            tar.extractall(untar_path)
+
+        def safe_members(tar):
+            """Filter members to prevent path traversal attacks."""
+            safe_files = []
+            for member in tar.getmembers():
+                # Normalize path and ensure it's within the extraction folder
+                if not member.name.startswith("/") and ".." not in member.name:
+                    safe_files.append(member)
+                else:
+                    logger.warning(f"Skipping unsafe file: {member.name}")
+            return safe_files
+
+        tf = tarfile.open(path, mode="r")
+        tf.extractall(untar_path, members=safe_members(tf))
+
     else:
         raise RuntimeError(f"Unknown NN Archive path: `{path}`")