Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sequence number inheritence to all parsers #158

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

aljazkonec1
Copy link
Contributor

This PR adds inheritance of frame sequence numbers to all parser output messages. When a frame is created in camera node it has a sequence number, this number is then forwarded (similarly like timestamp) in nodes that manipulate the frame such as NeuralNetwork, ImageManipV2, ....

To keep forwarding consistent with these nodes, I added it to all message outputs of parsers.

In addition I also added a small change to Text Detection post processing.

@github-actions github-actions bot added the parsers Changes affecting ml.parsers label Jan 9, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 3.84615% with 25 lines in your changes missing coverage. Please review.

Project coverage is 35.93%. Comparing base (b93f10f) to head (ae86988).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
depthai_nodes/ml/parsers/xfeat.py 0.00% 6 Missing ⚠️
depthai_nodes/ml/parsers/classification.py 0.00% 1 Missing ⚠️
...epthai_nodes/ml/parsers/classification_sequence.py 0.00% 1 Missing ⚠️
depthai_nodes/ml/parsers/embeddings.py 0.00% 1 Missing ⚠️
depthai_nodes/ml/parsers/fastsam.py 0.00% 1 Missing ⚠️
depthai_nodes/ml/parsers/hrnet.py 0.00% 1 Missing ⚠️
depthai_nodes/ml/parsers/image_output.py 0.00% 1 Missing ⚠️
depthai_nodes/ml/parsers/keypoints.py 0.00% 1 Missing ⚠️
depthai_nodes/ml/parsers/lane_detection.py 0.00% 1 Missing ⚠️
depthai_nodes/ml/parsers/map_output.py 0.00% 1 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
- Coverage   36.15%   35.93%   -0.22%     
==========================================
  Files          70       70              
  Lines        3986     4010      +24     
==========================================
  Hits         1441     1441              
- Misses       2545     2569      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aljazkonec1 aljazkonec1 merged commit 7529260 into main Jan 13, 2025
10 of 11 checks passed
@aljazkonec1 aljazkonec1 deleted the add-sequene-numbers-messages branch January 13, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsers Changes affecting ml.parsers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants