Fix finding jsoncpp #980
Merged
Fix finding jsoncpp #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Serafadam thanks! How did you hit into that issue? Including core into some project that already uses I'm thinking if we should do a bugfix release or not... |
|
This occurs when builting RTABMap standalone with DepthAI support. I think this could warrant a bugfix release |
moratom
approved these changes
Mar 14, 2024
danzvara
reviewed
Mar 25, 2024
cmake/depthaiDependencies.cmake
Outdated
|
|
||
| find_package(jsoncpp QUIET) | ||
| if(NOT TARGET JsonCpp::JsonCpp) | ||
| find_package(jsoncpp QUIET) |
There was a problem hiding this comment.
@Serafadam I tried using the PR on OSX, but the problem persists. However I found that asking hunter to install the package does the job. So maybe the following could help?
Suggested change
| find_package(jsoncpp QUIET) | |
| hunter_add_package(jsoncpp) | |
| find_package(jsoncpp QUIET) |
There was a problem hiding this comment.
@Serafadam would you be able to check if the change from @danzvara works for you?
Using hunter to find it should be fine IMO. CC: @zrezke for v2.26
moratom
pushed a commit
that referenced
this pull request
Apr 3, 2024
Updating docs for stereo depth video
This was referenced Apr 16, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes multi-include bug that occurs for jsoncpp.
More information open-source-parsers/jsoncpp#1356