luv_cfpcall: Fix stack balancing after an uncaught error #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwild1
force-pushed
the
fix/balance-stack-on-uncaught-error
branch
from
bbc627a to
219c88d
Compare
|
I just force-pushed an updated commit, as I found a second place where luaL_tolstring() is used but the result is not removed. |
|
Please add a test to cover this PR. |
|
I don't know how - do you have any suggestions? Unbalanced stack cannot be detected from Lua. |
That's true, ignore it. |
The default error handling code for printing uncaught errors uses luaL_tolstring(). This returns the resulting string, but also pushes it onto the stack. After we have printed it, it is safe to pop from the stack. Leaving it on the stack causes the stack to be unbalanced. Fixes luvit#735 (where a test case can be found)
mwild1
force-pushed
the
fix/balance-stack-on-uncaught-error
branch
from
219c88d to
09a98a4
Compare
Sorry, thought I pushed a fix for that yesterday. Just updated the branch now. |
zhaozg
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default error handling code for printing uncaught errors uses luaL_tolstring(). This returns the resulting string, but also pushes it onto the stack. After we have printed it, it is safe to pop from the stack.
Leaving it on the stack causes the stack to be unbalanced.
Fixes #735 (where a test case can be found)