fix #564, invalid thread argument causes crash. #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erw7
force-pushed
the
fix-luv-new-thread
branch
2 times, most recently
from
c142d0a to
c7950a6
Compare
zhaozg
approved these changes
Sep 18, 2021
erw7
force-pushed
the
fix-luv-new-thread
branch
from
c7950a6 to
bf07594
Compare
|
Would you like to add some test about this? |
Yes, I would like to add a test. If I link to neovim, it looks like the problem has been solved. However, luajit still crash SIGABRT (core dumped). I'll give it some more consideration. |
Change luv_work_cb to run in protected mode and throw an error in luv_thread_arg_set if an argument of an impermissible type is passed.
erw7
force-pushed
the
fix-luv-new-thread
branch
from
bf07594 to
cac3c27
Compare
zhaozg
reviewed
Sep 19, 2021
|
@erw7 Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #564 with a different approach than #565.
Change
luv_work_cb()to run in protected mode and throw an error inluv_thread_arg_set()if an argument of an impermissible type is passed. It's a little more complicated, but I've integrated it intoneovimand it seems to be working.