udp: Add udp_set_source_membership binding + improve udp_set_membership #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows the interface argument of udp_set_membership to be nil (meaning a NULL const char* passed to uv_udp_set_membership). This was needed to be able to port the libuv multicast join tests - Adds a binding for udp_set_source_membership (contributes towards luvit#410) - Ports the test-udp-multicast-join and test-udp-multicast-join6 tests from libuv
|
Valgrind failure is a libuv bug (same failure happens when running the Libuv test directly), will file an upstream issue. EDIT: libuv/libuv#2840 |
…et_source_membership
squeek502
force-pushed
the
udp-set-source-membership
branch
from
5a9f2a8 to
46572c3
Compare
zhaozg
approved these changes
May 11, 2020
This will allow CI to pass in the meantime, and then we can revert this commit when we update to a fixed libuv version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the added test cases might not be portable. Libuv has some special handling for specific platforms that hasn't been ported to luv:
EDIT: These might be solved by 46572c3 and 356968c
EDIT#2: Forced the OSX jobs to run and confirmed that the tests pass there: https://travis-ci.org/github/luvit/luv/builds/685548492