Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump libuv to 1.35.0 #471

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Bump libuv to 1.35.0 #471

merged 2 commits into from
Mar 31, 2020

Conversation

squeek502
Copy link
Member

Changelog: https://github.com/libuv/libuv/releases/tag/v1.35.0

Despite the minor version bump, there doesn't seem to be any new or changed API's from my reading of the changelog. Let me know if I missed anything in there that we need to update our bindings for.

@squeek502
Copy link
Member Author

squeek502 commented Mar 30, 2020

Whoops, missed this:

I'm considering libuv/libuv@3d71366 to be semver-minor due to the addition of UV_UDP_MMSG_CHUNK. That would make this release v1.35.0.


EDIT: Added an (untested) attempt at handling UV_UDP_MMSG_CHUNK based on the Libuv docs. From the commit message:

This is my best guess at how it should be handled; there are no examples or tests in Libuv or Node of how to handle this flag (yet?)

EDIT#2: Asked for clarification: libuv/libuv#2532 (comment)

This is my best guess at how it should be handled; there are no examples or tests in Libuv or Node of how to handle this flag (yet?)
@SinisterRectus
Copy link
Member

Don't worry about documenting the new field. I've been working on an big docs update that should be done before the end of the week.

@squeek502
Copy link
Member Author

I'm not sure the flag is of any use on the Lua side, just thought I'd add it for completeness.

@squeek502 squeek502 merged commit 404f1be into luvit:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants