Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky UDP test in CI #704

Closed
squeek502 opened this issue Jun 3, 2024 · 3 comments · Fixed by #706
Closed

Flaky UDP test in CI #704

squeek502 opened this issue Jun 3, 2024 · 3 comments · Fixed by #706

Comments

@squeek502
Copy link
Member

squeek502 commented Jun 3, 2024

Some CI runs have been failing with:

Uncaught Error: ./tests/test-udp.lua:229: EBUSY: resource busy or locked
stack traceback:
	[C]: in function 'assert'
	./tests/test-udp.lua:229: in function <./tests/test-udp.lua:201>
	[C]: in function 'luv.run'
	./lib/tap.lua:61: in function <./lib/tap.lua:48>
	[C]: in function 'xpcall'
	./lib/tap.lua:48: in upvalue 'run'
	./lib/tap.lua:146: in function 'lib/tap'
	tests/run.lua:23: in main chunk
	[C]: in ?

The assert that's failing is

assert(not err, err)

Only seen on macos-latest so far, unsure if it affects others.

squeek502 added a commit to squeek502/luv that referenced this issue Jun 3, 2024
@squeek502 squeek502 changed the title Flaky test in CI Flaky UDP test in CI Jun 3, 2024
@squeek502 squeek502 added the tests label Jun 3, 2024
@zhaozg
Copy link
Member

zhaozg commented Jun 3, 2024

Manually re-run fails jobs will ok.
It's better better call it again when got EBUSY.

@squeek502
Copy link
Member Author

Note that the test is based on https://github.com/libuv/libuv/blob/v1.x/test/test-udp-multicast-join.c which doesn't seem to have this problem.

@zhaozg
Copy link
Member

zhaozg commented Jun 4, 2024

Maybe later I will do some analysis and testing. now we just skip it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants