Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"leaks - reading file sync" test fails on i386/1.30.1 #428

Closed
jamessan opened this issue Oct 29, 2019 · 0 comments · Fixed by #432
Closed

"leaks - reading file sync" test fails on i386/1.30.1 #428

jamessan opened this issue Oct 29, 2019 · 0 comments · Fixed by #432

Comments

@jamessan
Copy link
Contributor

jamessan commented Oct 29, 2019

The Debian i386 build failed with the below test failure:

  1024	8609792
  2048	14700544
  3072	14700544
  4096	14700544
  5120	11386880
  6144	14532608
  7168	14532608
  8192	14761984
  { before = 8609792, after = 14761984 }
  ./tests/test-leaks.lua:24: assertion failed!
  stack traceback:
  	[C]: in function 'assert'
  	./tests/test-leaks.lua:24: in upvalue 'bench'
  	./tests/test-leaks.lua:102: in field 'fn'
  	./lib/tap.lua:53: in function <./lib/tap.lua:42>
  	[C]: in function 'xpcall'
  	./lib/tap.lua:42: in upvalue 'run'
  	./lib/tap.lua:136: in function 'lib/tap'
  	tests/run.lua:35: in main chunk
not ok 25 leaks - reading file sync

This was with the app shim (dynamically linked against luv) I've previously mentioned. The test passed when using lua to directly run the tests.

squeek502 added a commit that referenced this issue Nov 3, 2019
- Adds a 'Check' stage to the CI that runs before the general 'Test' stage
- Adds Valgrind check
- Adds LSAN/ASAN/UBSAN check
- Adds a "binding coverage" check script to catch any unbound functions when we update to new Libuv versions. Added the unbound functions in #410 as exceptions for now; they should be removed from the $skipped array as they are resolved.
- Deprecated test-leaks.lua and moved it to manual-test-leaks.lua since Valgrind/ASAN is much better at detecting leaks. This has a side benefit of speeding up our test suite a bit.
- Closes #395, #428, #429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant