Improvements to strip #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Writing to a `Cursor<Vec<u8>>` can never fail.
This is a convenience method that works on UTF-8 strings, and relies on the invariant that ANSI escape codes are always in the range 0..128.
|
@luser were you still interested in this? |
|
Oops, yeah! |
Closed
sholderbach
added a commit
to sholderbach/strip-ansi-escapes
that referenced
this pull request
Aug 8, 2023
As mentioned in luser#17, luser#11 among other things changed the public API in a way that causes failures to build. Thus those changes should be released under the `0.2.0` version to not break existing or new projects that don't lock the version to `0.1.1`. To close luser#17, and stop churn for the ecosystem `0.1.2` would need to be yanked as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9.
Closes #10.
#9 is a breaking change, but a good one I think!