Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): get unique discovery file and update urls #200

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

chloecarton
Copy link
Contributor

in order to be less restrictive on the url to get the discovery file content, we get the same file independently from the base_url and update the file content with the baseUrl on load.

@chloecarton chloecarton force-pushed the fix/get-discovery-url branch from 9f4b2af to 13f3f9d Compare October 2, 2024 14:28
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.01%. Comparing base (170ba8d) to head (59f9d0b).
Report is 5 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
+ Coverage   85.81%   86.01%   +0.20%     
==========================================
  Files          16       16              
  Lines         853      851       -2     
  Branches      171      169       -2     
==========================================
  Hits          732      732              
+ Misses         78       77       -1     
+ Partials       43       42       -1     
Flag Coverage Δ
unittests 86.01% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lumapps/api/base_client.py 80.48% <100.00%> (+0.55%) ⬆️
lumapps/api/client.py 95.23% <ø> (ø)

@chloecarton chloecarton force-pushed the fix/get-discovery-url branch 5 times, most recently from 9df3988 to e3c4c28 Compare October 7, 2024 11:43
@chloecarton chloecarton marked this pull request as ready for review October 21, 2024 12:30
@chloecarton chloecarton requested review from lumautomation and a team as code owners October 21, 2024 12:30
Copy link
Contributor

@beroussel beroussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise 👌

@chloecarton chloecarton requested a review from beroussel October 23, 2024 07:18
@jssevestre jssevestre merged commit 036ce76 into master Oct 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants