Tentative: multi-dimensional outputs for pytorch and paddle #1631
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How this was done
I made it in two steps:
tensorflow
'sdeeponet.py
to a separate filedeeponet_strategy.py
so that all backends can share itpytorch
andpaddle
following the same way (with few synatx adaptions)Remaining Issue
I noted that in
call(self, x_func, x_loc, training=False)
ofDeepONetStrategy
, the argumenttraining
is completely unused. It is kept in this PR because I don't know if it serves some other purpose. I suggest removal of it.Tests
A file
test_strat.py
(renamed totest_start.txt
for uploading) is attached in this description. It tests all the model classes (DeepONet
,DeepONetCartesianProd
,PODDeepONet
) and strategy settings (single, independent, split both, split branch, split trunk), making sure that the forward pass yields the correct output shape. To reproduce the tests, put this file under the top directory and runAnd you should see no errors.
test_strat.txt