🐛 Delete all comments when deleting account

[lukevella]

We need to delete all comments in polls belonging to a deleted user.

Summary by CodeRabbit

• New Features
  • Enhanced comment deletion functionality: users can now delete comments associated with their user ID or linked to specific polls, increasing the flexibility of comment management.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 22, 2024 4:22pm
landing	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Aug 22, 2024 4:22pm

[coderabbitai]

Walkthrough

The changes implement an enhancement to the user router's comment deletion logic. Previously, comments were deleted solely based on the user's ID. The updated logic now also allows comments to be deleted if they are linked to specific polls identified by a pollIds array. This broadens the criteria for comment deletions while maintaining the existing control flow.

Changes

File	Change Summary
.../trpc/routers/user.ts	Expanded comment deletion logic to include pollId in addition to userId.

Poem

🐇 In the meadow where comments play,
A new rule hops into the fray.
With polls and users hand in hand,
Deletions dance across the land!
A joyful tweak, a code delight,
Hooray for changes, oh what a sight! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 550eebd and 53c5998.

Files selected for processing (1)

• packages/backend/trpc/routers/user.ts (1 hunks)

Additional comments not posted (1)

packages/backend/trpc/routers/user.ts (1)

67-67: LGTM! Verify the impact of broader comment deletion logic.

The updated logic for deleting comments based on both pollId and userId aligns with the PR objectives and enhances data integrity.

However, ensure that this broader deletion logic does not unintentionally affect other parts of the application.

Run the following script to verify the usage and impact of the delete mutation:

Verification successful

---

Broader deletion logic verified successfully.

The delete mutation is used in expected contexts, including tests and UI components, ensuring comprehensive user data deletion without unintended side effects.

• File: packages/backend/trpc/routers/user.ts - Direct usage in mutation logic.
• File: apps/web/tests/authentication.spec.ts - Usage in tests, ensuring correctness.
• File: apps/web/src/app/[locale]/(admin)/settings/profile/delete-account-dialog.tsx - Usage in UI component for account deletion.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage and impact of the `delete` mutation.

# Test: Search for the usage of the `delete` mutation. Expect: No unintended side effects.
rg --type typescript -A 5 $'user.delete'

Length of output: 74

---

Script:

#!/bin/bash
# Description: Verify the usage and impact of the `delete` mutation.

# Test: Search for the usage of the `delete` mutation. Expect: No unintended side effects.
rg -A 5 'user.delete'

Length of output: 1360