Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Execute lint fix on violating files for standard linting format #263

Merged

Conversation

JackHowa
Copy link
Contributor

@JackHowa JackHowa commented Aug 7, 2023

  • Really like your plugin and how it works with the spec! 👍
  • Noticed some linting errors that could be fixed quickly with the singlequote ones with standard fix. Let me know if there's documentation to add; I know these things can be annoying to do manually.

Before

npm run lint

> [email protected] lint
> standardx src/**/*.ts src/*.ts | snazzy

standardx: Use JavaScript Standard Style (tweaked by standardx) (https://github.com/standard/standardx)
standardx: Run `standardx --fix` to automatically fix some problems.

design-tokens/src/transformer/standardTransformer.ts
  261:28  error  Unnecessary escape character: \.
  261:32  error  Unnecessary escape character: \_
  261:34  error  Unnecessary escape character: \/
  261:36  error  Unnecessary escape character: \@
  261:38  error  Unnecessary escape character: \+
  261:40  error  Unnecessary escape character: \&
  261:42  error  Unnecessary escape character: \:
  267:37  error  Strings must use singlequote
  267:42  error  Strings must use singlequote

✖ 9 problems

After

  • No linting errors
  • Manually removed unnecessary regex characters
 design-tokens % npm run lint    

> [email protected] lint
> standardx src/**/*.ts src/*.ts | snazzy

 design-tokens % 

@coveralls
Copy link

coveralls commented Aug 14, 2023

Pull Request Test Coverage Report for Build 5852653686

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.294%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/transformer/standardTransformer.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 5852630487: 0.0%
Covered Lines: 492
Relevant Lines: 714

💛 - Coveralls

@lukasoppermann lukasoppermann merged commit 777f016 into lukasoppermann:main Aug 14, 2023
@JackHowa JackHowa deleted the lint-fix-command-standardx branch August 14, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants