Clippy fixes

src/lib.rs

@@ -1072,7 +1072,7 @@ mod tests {
         let commit_oid_short = binding.as_str().unwrap();
 
         let commit_hash = format!("{}", commit_oid);
-        let commit_hash_short = format!("{}", commit_oid_short);
+        let commit_hash_short = commit_oid_short.to_string();
 
         assert!(commit_hash.starts_with(&commit_hash_short));
 
@@ -1156,7 +1156,7 @@ mod tests {
         let commit_oid_short = binding.as_str().unwrap();
 
         let commit_hash = format!("{}", commit_oid);
-        let commit_hash_short = format!("{}", commit_oid_short);
+        let commit_hash_short = commit_oid_short.to_string();
 
         assert!(commit_hash.starts_with(&commit_hash_short));
 

src/util.rs

@@ -128,7 +128,7 @@ pub fn get_repo_head(
             Ok(Some((
                 branch.map(ToString::to_string),
                 format!("{}", commit),
-                format!("{}", commit_short.as_str().unwrap_or_default()),
+                commit_short.as_str().unwrap_or_default().to_string(),
             )))
         }
         Err(ref e)

tests/testbox_tests.rs

@@ -63,11 +63,11 @@ fn main() {
     /// Hold on to the tempdir, it will be removed when dropped!
     fn create(self) -> io::Result<tempfile::TempDir> {
         fs::DirBuilder::new()
-            .create(&self.root.path().join("src"))
+            .create(self.root.path().join("src"))
             .unwrap();
         for (name, content) in self.files {
             let fname = self.root.path().join(name);
-            let mut file = fs::File::create(&fname)?;
+            let mut file = fs::File::create(fname)?;
             file.write_all(&content)?;
         }
         Ok(self.root)
@@ -274,7 +274,7 @@ fn main() {
     let mut f = std::fs::OpenOptions::new()
         .write(true)
         .truncate(true)
-        .open(&root.path().join("src/main.rs"))
+        .open(root.path().join("src/main.rs"))
         .unwrap();
     f.write_all(
         r#"