Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kirby 3.6 - Internal error in the Versions plugin (error code user-not-logged-in) #7

Closed
raphaelsaunier opened this issue Dec 16, 2021 · 3 comments
Labels
type: bug 🐛 Is a bug; fixes a bug

Comments

@raphaelsaunier
Copy link

Describe the bug

After upgrading to the latest version of Kirby (3.6.1.1) and the latest version of this plugin (1.0.1) , it is impossible to open the panel as a logged out user.

No exception is thrown for a user who is already authenticated.

Steps to reproduce

  1. Go to https://example.com/panel
  2. See the following error:
Kirby\Exception\LogicException thrown with message "Internal error in the Versions plugin (error code user-not-logged-in)"

Stacktrace:
#12 Kirby\Exception\LogicException in /Users/raphaelsaunier/code/project-name/site/plugins/versions/src/classes/Plugin.php:180
#11 LukasBestle\Versions\Plugin:hasPermission in /Users/raphaelsaunier/code/project-name/site/plugins/versions/src/config/areas.php:7
#10 Kirby\Filesystem\F:{closure} in /Users/raphaelsaunier/code/project-name/vendor/getkirby/cms/src/Cms/Loader.php:170
#9 Kirby\Cms\Loader:resolve in /Users/raphaelsaunier/code/project-name/vendor/getkirby/cms/src/Cms/Loader.php:92
#8 Kirby\Cms\Loader:areas in /Users/raphaelsaunier/code/project-name/vendor/getkirby/cms/src/Panel/Panel.php:61
#7 Kirby\Panel\Panel:areas in /Users/raphaelsaunier/code/project-name/vendor/getkirby/cms/src/Panel/Panel.php:302
#6 Kirby\Panel\Panel:router in /Users/raphaelsaunier/code/project-name/vendor/getkirby/cms/config/routes.php:101
#5 Kirby\Http\Route:{closure} in [internal]:0
#4 Closure:call in /Users/raphaelsaunier/code/project-name/vendor/getkirby/cms/src/Http/Router.php:111
#3 Kirby\Http\Router:call in /Users/raphaelsaunier/code/project-name/vendor/getkirby/cms/src/Cms/App.php:345
#2 Kirby\Cms\App:call in /Users/raphaelsaunier/code/project-name/vendor/getkirby/cms/src/Cms/App.php:1086
#1 Kirby\Cms\App:render in /Users/raphaelsaunier/code/project-name/index.php:9
#0 require in /Users/raphaelsaunier/.composer/vendor/laravel/valet/server.php:211

Expected behavior

I should be able to at least log in. 😅

Additional context

image

Technical details

  • Plugin version: 1.0.1
  • Kirby version:
  • Browser: not relevant
  • Server operating system: macOS
  • git --version on the server: 2.30.1 (Apple Git-130)
@raphaelsaunier raphaelsaunier added the type: bug 🐛 Is a bug; fixes a bug label Dec 16, 2021
@lukasbestle
Copy link
Owner

Sorry, that's a pretty obvious bug. 😅

I'll fix it ASAP.

@raphaelsaunier
Copy link
Author

No worries man! Thanks for all the time you put into this useful plugin. 🙏

After using it for a couple of months I noticed some other rough edges; if I find the time I'll try to contribute or at least open a couple of issues.

@lukasbestle
Copy link
Owner

Fixed in a new plugin release 1.0.2, which also comes with some other minor enhancements. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

No branches or pull requests

2 participants