Merge pull request #1172 from lukas-krecan/dep-clean

Make dependencies explicit
lukas-krecan · Sep 14, 2022 · 3034b57 · 3034b57
2 parents 8aa88a4 + d18e816
commit 3034b57
Show file tree

Hide file tree

Showing 32 changed files with 137 additions and 69 deletions.
diff --git a/micronaut/shedlock-micronaut/pom.xml b/micronaut/shedlock-micronaut/pom.xml
@@ -43,6 +43,8 @@
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
+            <version>${logback.version}</version>
+            <scope>test</scope>
         </dependency>
         <dependency>
             <groupId>org.junit.jupiter</groupId>
@@ -62,7 +64,13 @@
         <dependency>
             <groupId>org.mockito</groupId>
             <artifactId>mockito-core</artifactId>
-            <version>4.8.0</version>
+            <version>${mockito.version}</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.assertj</groupId>
+            <artifactId>assertj-core</artifactId>
+            <version>${assertj.version}</version>
             <scope>test</scope>
         </dependency>
     </dependencies>

diff --git a/micronaut/test/micronaut-jdbc-new/pom.xml b/micronaut/test/micronaut-jdbc-new/pom.xml
@@ -106,6 +106,18 @@
             <artifactId>h2</artifactId>
             <version>2.1.214</version>
         </dependency>
+        <dependency>
+            <groupId>org.assertj</groupId>
+            <artifactId>assertj-core</artifactId>
+            <version>${assertj.version}</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.awaitility</groupId>
+            <artifactId>awaitility</artifactId>
+            <version>${awaitility.version}</version>
+            <scope>test</scope>
+        </dependency>
     </dependencies>
     <build>
         <plugins>

diff --git a/micronaut/test/micronaut-jdbc-template/pom.xml b/micronaut/test/micronaut-jdbc-template/pom.xml
@@ -105,6 +105,18 @@
             <artifactId>h2</artifactId>
             <version>2.1.214</version>
         </dependency>
+        <dependency>
+            <groupId>org.assertj</groupId>
+            <artifactId>assertj-core</artifactId>
+            <version>${assertj.version}</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.awaitility</groupId>
+            <artifactId>awaitility</artifactId>
+            <version>${awaitility.version}</version>
+            <scope>test</scope>
+        </dependency>
     </dependencies>
     <build>
         <plugins>

diff --git a/micronaut/test/micronaut-jdbc/pom.xml b/micronaut/test/micronaut-jdbc/pom.xml
@@ -105,6 +105,18 @@
             <artifactId>h2</artifactId>
             <version>2.1.214</version>
         </dependency>
+        <dependency>
+            <groupId>org.assertj</groupId>
+            <artifactId>assertj-core</artifactId>
+            <version>${assertj.version}</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.awaitility</groupId>
+            <artifactId>awaitility</artifactId>
+            <version>${awaitility.version}</version>
+            <scope>test</scope>
+        </dependency>
     </dependencies>
     <build>
         <plugins>

diff --git a/pom.xml b/pom.xml
@@ -78,70 +78,12 @@
         <micronaut.version>2.5.13</micronaut.version>
         <micronaut-data.version>2.5.0</micronaut-data.version>
         <logback.version>1.2.11</logback.version>
+        <awaitility.version>4.2.0</awaitility.version>
+        <assertj.version>3.23.1</assertj.version>
+        <mockito.version>4.8.0</mockito.version>
+        <slf4j.version>1.7.36</slf4j.version>
     </properties>
 
-    <dependencies>
-        <dependency>
-            <groupId>org.slf4j</groupId>
-            <artifactId>slf4j-api</artifactId>
-            <version>1.7.36</version>
-        </dependency>
-
-        <dependency>
-            <groupId>com.google.code.findbugs</groupId>
-            <artifactId>jsr305</artifactId>
-            <version>3.0.2</version>
-            <scope>provided</scope>
-        </dependency>
-
-        <dependency>
-            <groupId>org.junit.jupiter</groupId>
-            <artifactId>junit-jupiter</artifactId>
-            <scope>test</scope>
-        </dependency>
-
-        <dependency>
-            <groupId>org.awaitility</groupId>
-            <artifactId>awaitility</artifactId>
-        </dependency>
-
-        <dependency>
-            <groupId>org.assertj</groupId>
-            <artifactId>assertj-core</artifactId>
-        </dependency>
-    </dependencies>
-
-    <dependencyManagement>
-        <dependencies>
-            <dependency>
-                <groupId>org.junit.jupiter</groupId>
-                <artifactId>junit-jupiter</artifactId>
-                <version>${junit.version}</version>
-                <scope>test</scope>
-            </dependency>
-
-            <dependency>
-                <groupId>org.awaitility</groupId>
-                <artifactId>awaitility</artifactId>
-                <version>4.2.0</version>
-                <scope>test</scope>
-            </dependency>
-
-            <dependency>
-                <groupId>org.assertj</groupId>
-                <artifactId>assertj-core</artifactId>
-                <version>3.23.1</version>
-                <scope>test</scope>
-            </dependency>
-            <dependency>
-                <groupId>ch.qos.logback</groupId>
-                <artifactId>logback-classic</artifactId>
-                <version>${logback.version}</version>
-                <scope>test</scope>
-            </dependency>
-        </dependencies>
-    </dependencyManagement>
-
     <build>
         <plugins>
             <plugin>

diff --git a/providers/arangodb/shedlock-provider-arangodb/pom.xml b/providers/arangodb/shedlock-provider-arangodb/pom.xml
@@ -33,6 +33,8 @@
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
+            <version>${logback.version}</version>
+            <scope>test</scope>
         </dependency>
 
         <dependency>

diff --git a/providers/cassandra/shedlock-provider-cassandra/pom.xml b/providers/cassandra/shedlock-provider-cassandra/pom.xml
@@ -58,6 +58,7 @@
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
+            <version>${logback.version}</version>
             <scope>test</scope>
         </dependency>
     </dependencies>

diff --git a/providers/consul/shedlock-provider-consul/pom.xml b/providers/consul/shedlock-provider-consul/pom.xml
@@ -48,11 +48,13 @@
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
+            <version>${logback.version}</version>
+            <scope>test</scope>
         </dependency>
         <dependency>
             <groupId>org.mockito</groupId>
             <artifactId>mockito-core</artifactId>
-            <version>4.8.0</version>
+            <version>${mockito.version}</version>
             <scope>test</scope>
         </dependency>
     </dependencies>

diff --git a/providers/couchbase/shedlock-provider-couchbase-javaclient/pom.xml b/providers/couchbase/shedlock-provider-couchbase-javaclient/pom.xml
@@ -41,6 +41,8 @@
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
+            <version>${logback.version}</version>
+            <scope>test</scope>
         </dependency>
 	</dependencies>
 

diff --git a/providers/couchbase/shedlock-provider-couchbase-javaclient3/pom.xml b/providers/couchbase/shedlock-provider-couchbase-javaclient3/pom.xml
@@ -41,6 +41,8 @@
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
+            <version>${logback.version}</version>
+            <scope>test</scope>
         </dependency>
     </dependencies>
 

diff --git a/providers/dynamodb/shedlock-provider-dynamodb/pom.xml b/providers/dynamodb/shedlock-provider-dynamodb/pom.xml
@@ -67,6 +67,8 @@
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
+            <version>${logback.version}</version>
+            <scope>test</scope>
         </dependency>
     </dependencies>
 

diff --git a/providers/dynamodb/shedlock-provider-dynamodb2/pom.xml b/providers/dynamodb/shedlock-provider-dynamodb2/pom.xml
@@ -59,6 +59,8 @@
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
+            <version>${logback.version}</version>
+            <scope>test</scope>
         </dependency>
     </dependencies>
 

diff --git a/providers/elasticsearch/shedlock-provider-elasticsearch/pom.xml b/providers/elasticsearch/shedlock-provider-elasticsearch/pom.xml
@@ -52,6 +52,7 @@
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
+            <version>${logback.version}</version>
             <scope>test</scope>
         </dependency>
     </dependencies>

diff --git a/providers/elasticsearch/shedlock-provider-elasticsearch8/pom.xml b/providers/elasticsearch/shedlock-provider-elasticsearch8/pom.xml
@@ -72,6 +72,7 @@
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
+            <version>${logback.version}</version>
             <scope>test</scope>
         </dependency>
     </dependencies>

diff --git a/providers/etcd/shedlock-provider-etcd-jetcd/pom.xml b/providers/etcd/shedlock-provider-etcd-jetcd/pom.xml
@@ -51,6 +51,7 @@
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
+            <version>${logback.version}</version>
             <scope>test</scope>
         </dependency>
     </dependencies>

diff --git a/providers/jdbc/shedlock-provider-jdbc-template/pom.xml b/providers/jdbc/shedlock-provider-jdbc-template/pom.xml
@@ -34,12 +34,13 @@
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
+            <version>${logback.version}</version>
             <scope>test</scope>
         </dependency>
         <dependency>
             <groupId>org.mockito</groupId>
             <artifactId>mockito-core</artifactId>
-            <version>4.8.0</version>
+            <version>${mockito.version}</version>
             <scope>test</scope>
         </dependency>
     </dependencies>

diff --git a/providers/jdbc/shedlock-test-support-jdbc/pom.xml b/providers/jdbc/shedlock-test-support-jdbc/pom.xml
@@ -117,12 +117,14 @@
         <dependency>
             <groupId>org.assertj</groupId>
             <artifactId>assertj-core</artifactId>
+            <version>${assertj.version}</version>
             <scope>compile</scope>
         </dependency>
 
         <dependency>
             <groupId>org.junit.jupiter</groupId>
             <artifactId>junit-jupiter</artifactId>
+            <version>${junit.version}</version>
             <scope>compile</scope>
         </dependency>
     </dependencies>

diff --git a/providers/memcached/shedlock-provider-memcached-spy/pom.xml b/providers/memcached/shedlock-provider-memcached-spy/pom.xml
@@ -52,6 +52,7 @@
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
+            <version>${logback.version}</version>
             <scope>test</scope>
         </dependency>
     </dependencies>

diff --git a/providers/mongo/shedlock-provider-mongo-reactivestreams/pom.xml b/providers/mongo/shedlock-provider-mongo-reactivestreams/pom.xml
@@ -41,6 +41,7 @@
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
+            <version>${logback.version}</version>
             <scope>test</scope>
         </dependency>
     </dependencies>

diff --git a/providers/mongo/shedlock-provider-mongo/pom.xml b/providers/mongo/shedlock-provider-mongo/pom.xml
@@ -41,6 +41,7 @@
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
+            <version>${logback.version}</version>
             <scope>test</scope>
         </dependency>
     </dependencies>

diff --git a/providers/neo4j/shedlock-provider-neo4j/pom.xml b/providers/neo4j/shedlock-provider-neo4j/pom.xml
@@ -38,6 +38,7 @@
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
+            <version>${logback.version}</version>
             <scope>test</scope>
         </dependency>
     </dependencies>

diff --git a/providers/opensearch/shedlock-provider-opensearch/pom.xml b/providers/opensearch/shedlock-provider-opensearch/pom.xml
@@ -45,6 +45,7 @@
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
+            <version>${logback.version}</version>
             <scope>test</scope>
         </dependency>
     </dependencies>

diff --git a/providers/r2dbc/shedlock-provider-r2dbc/pom.xml b/providers/r2dbc/shedlock-provider-r2dbc/pom.xml
@@ -91,6 +91,7 @@
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
+            <version>${logback.version}</version>
             <scope>test</scope>
         </dependency>
     </dependencies>

diff --git a/providers/redis/shedlock-provider-redis-jedis/pom.xml b/providers/redis/shedlock-provider-redis-jedis/pom.xml
@@ -48,6 +48,7 @@
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
+            <version>${logback.version}</version>
             <scope>test</scope>
         </dependency>
     </dependencies>

diff --git a/providers/redis/shedlock-provider-redis-jedis4/pom.xml b/providers/redis/shedlock-provider-redis-jedis4/pom.xml
@@ -48,6 +48,7 @@
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
+            <version>${logback.version}</version>
             <scope>test</scope>
         </dependency>
     </dependencies>

diff --git a/providers/redis/shedlock-provider-redis-spring/pom.xml b/providers/redis/shedlock-provider-redis-spring/pom.xml
@@ -69,6 +69,7 @@
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
+            <version>${logback.version}</version>
             <scope>test</scope>
         </dependency>
     </dependencies>

diff --git a/providers/zookeeper/shedlock-provider-zookeeper-curator/pom.xml b/providers/zookeeper/shedlock-provider-zookeeper-curator/pom.xml
@@ -51,6 +51,7 @@
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
+            <version>${logback.version}</version>
             <scope>test</scope>
         </dependency>
     </dependencies>