Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RLHF example #4

Closed
wants to merge 2 commits into from
Closed

Conversation

younesbelkada
Copy link

@younesbelkada younesbelkada commented Feb 16, 2023

What does this PR do?

First of all thanks a lot for bringing this repository and making the LION optimizer more accessible
I did some quick experiments in the context of RLHF using Transformers Reinforcement Library (trl), and managed to get an interesting convergence using this optimizer (by diving the learning rate by 3 as suggested), and I wanted to share it here, and why not merge the example script on this repository and/or add few instructions about this in the README

Related huggingface/trl#152

@lucidrains
Copy link
Owner

@younesbelkada ah, thanks for the PR, but i feel that's a bit outside the scope

would welcome that you share a few training runs in the discussion though. we don't even know if this optimizer will pass the test of time

@lucidrains lucidrains closed this Feb 16, 2023
@younesbelkada
Copy link
Author

Sure, no problem, here is the run I made: https://wandb.ai/distill-bloom/trl/runs/slgy199e?workspace=user-younesbelkada

And in comparison to adam:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants