Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
First of all thanks a lot for bringing this repository and making the LION optimizer more accessible
I did some quick experiments in the context of RLHF using Transformers Reinforcement Library (
trl
), and managed to get an interesting convergence using this optimizer (by diving the learning rate by 3 as suggested), and I wanted to share it here, and why not merge the example script on this repository and/or add few instructions about this in the READMERelated huggingface/trl#152