Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center tag icon #523

Merged
merged 2 commits into from
Mar 19, 2022
Merged

Center tag icon #523

merged 2 commits into from
Mar 19, 2022

Conversation

aaofyi
Copy link
Contributor

@aaofyi aaofyi commented Mar 14, 2022

Resolve issue #504.

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You moved the icon a bit. What feels like the solution but there is problem by doing this. By centering the icon the path will add some decimals to some points. If rendered on low pixel displays the icon will appear blurry. (See screenshot, left is yours). We can fix this by keep the points rounded. I fixed it by extended the tag icon so it centered again, but keeping the icon pixel perfect.

Screenshot 2022-03-15 at 19 43 15

icons/tag.svg Outdated
Comment on lines 12 to 13
<path d="m21.007 13.83-7.17 7.17a2 2 0 0 1-2.83 0l-8.59-8.58v-10h10l8.59 8.59a2 2 0 0 1 0 2.82z"/>
<line x1="7.417" x2="7.427" y1="7.42" y2="7.42"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<path d="m21.007 13.83-7.17 7.17a2 2 0 0 1-2.83 0l-8.59-8.58v-10h10l8.59 8.59a2 2 0 0 1 0 2.82z"/>
<line x1="7.417" x2="7.427" y1="7.42" y2="7.42"/>
<path d="M2 12V2h10l9.44 9.44a2 2 0 0 1 0 2.82l-7.18 7.18a2 2 0 0 1-2.82 0L2 12Z" />
<path d="M7 7h.01" />

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new problem appears to be the left-center point of the outside of the tag. That point is no longer rounded on full resolution. I attempted to resolve this but was unsuccessful while maintaining pixel perfection.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the best solution. Most important thing is that the icon not look blurry on low resolution screens

Co-authored-by: Eric Fennis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants