add package plus, minus, x, search, check icons #474
Conversation
There was a problem hiding this comment.
@Reund0 Nice icons! These are really welcome.
Did you read the Lucide Icon Design guide?
We like to see 1px padding of the 24x24 pixel grid. I see there is some place to move the icon a bit to the right to center it.
Also maybe you can try to increase the sub-icons in the corner a bit if it fits.
If you need any help let me know.
Other things we like to see is that the icon if formatted like all the other icons. See Global Attributes in icon design guide, or look a an other icon in the icons directory.
And at least please add some tags to the tags.json located in the root directory. This improves the search engine on the website. So other devs and designers will find your beautiful icons!
|
The package search icon seems a bit congested. @Reund0 Can you try increase the size of circle of magnifying glass? |
Is it okay to not have 2px spacing? |
Ah! I see, what you mean. That will be bit tricky 🤔 @ericfennis Do you think it would be good idea to keep the package icon edge to edge that way the children icon (not just search other icons as well) will get more space. |
|
@mittalyashu I think it's better to leave it centered, that matches better it the current package icon if used together. |
|
@Reund0 Can you also increase the size of the X a bit in the package-x icon? |
changed from 4x4 to 4.5x4.5
I increased its size from 4x4 to 4.5x4.5 but again is it okay to ignore 2px spacing? |
adding package group icons including:
package-plus icon,
package-minus icon,
package-search icon,
package-x icon,
package-check icon.