Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add egg icon #445

Merged
merged 4 commits into from
Jan 4, 2022
Merged

feat: add egg icon #445

merged 4 commits into from
Jan 4, 2022

Conversation

mittalyashu
Copy link
Member

@mittalyashu mittalyashu commented Nov 26, 2021

Zoom 100%
CleanShot 2021-11-26 at 17 41 18@2x CleanShot 2021-11-26 at 17 41 34@2x

Credit goes to feathericons/feather#83

@ericfennis
Copy link
Member

@mittalyashu hmm I'm not sure about the gloss line. I think without look a bit better with the others.

@mittalyashu
Copy link
Member Author

@ericfennis here's a comparison between egg with/without gloss line.

CleanShot 2021-12-26 at 21 13 26@2x

@Andreto
Copy link
Member

Andreto commented Dec 28, 2021

@mittalyashu Isn't it a bit too pointy? Real life egg for reference:
image

@ericfennis
Copy link
Member

I prefer the egg without gloss, but that is my preference. What do you think?

@mittalyashu
Copy link
Member Author

mittalyashu commented Dec 29, 2021

@Andreto that's true. Just by creating and outline shape it will only look like an oval shape without giving a clear visual representation of an egg.

@ericfennis Sure, we can remove the gloss. But the image @Andreto shared does have a gloss 😂

@Andreto
Copy link
Member

Andreto commented Dec 29, 2021

@mittalyashu I realize that your more exaggerated shape does look a lot better in true size.
image

@ericfennis Could the gloss perhaps work better if it was a bit smaller and actually followed the shape of the edge?
image

@mittalyashu
Copy link
Member Author

After comparing all four, I like the 4th one.

CleanShot 2021-12-29 at 22 15 42@2x

@ericfennis
Copy link
Member

@Andreto Yeah it is more about the gloss, we don't use it on other icons for example camera or smartphone. So that why I don't feel something for the gloss.

@mittalyashu I agree with you, 4th looks better!

@mittalyashu
Copy link
Member Author

@Andreto Since you've the source code of that 4th icon. You can override the changes to this PR or create a new one or can you share the source code?

@Andreto
Copy link
Member

Andreto commented Dec 31, 2021

@mittalyashu I was unable to push a commit to this pr. Could you perhaps turn on “Allow edits from maintainers.” ?

@mittalyashu
Copy link
Member Author

I was unable to push a commit to this pr. Could you perhaps turn on “Allow edits from maintainers.” ?

@Andreto It's already enabled.

Co-Authored-By: Yashu Mittal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants