-
-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add egg icon #445
feat: add egg icon #445
Conversation
@mittalyashu hmm I'm not sure about the gloss line. I think without look a bit better with the others. |
@ericfennis here's a comparison between egg with/without gloss line. |
@mittalyashu Isn't it a bit too pointy? Real life egg for reference: |
I prefer the egg without gloss, but that is my preference. What do you think? |
@Andreto that's true. Just by creating and outline shape it will only look like an oval shape without giving a clear visual representation of an egg. @ericfennis Sure, we can remove the gloss. But the image @Andreto shared does have a gloss 😂 |
@mittalyashu I realize that your more exaggerated shape does look a lot better in true size. @ericfennis Could the gloss perhaps work better if it was a bit smaller and actually followed the shape of the edge? |
@Andreto Yeah it is more about the gloss, we don't use it on other icons for example @mittalyashu I agree with you, 4th looks better! |
@Andreto Since you've the source code of that 4th icon. You can override the changes to this PR or create a new one or can you share the source code? |
@mittalyashu I was unable to push a commit to this pr. Could you perhaps turn on “Allow edits from maintainers.” ? |
@Andreto It's already enabled. |
Co-Authored-By: Yashu Mittal <[email protected]>
Credit goes to feathericons/feather#83