add bookmark-add icon
#413
Conversation
Signed-off-by: Sri Aspari <[email protected]>
There was a problem hiding this comment.
@siarie Awesome icon!
Can you rename it to bookmark-plus?
Then the naming matches with the other "plus" icons.
As optional you could apply some extra tags in "tags.json", like the word "add" so you can find it more easily on the lucide.dev website.
Signed-off-by: Sri Aspari <[email protected]>
|
Hi @ericfennis, I've rename it to |
There was a problem hiding this comment.
@siarie One thing, I see you used half pixels in the plus part.
That will result in blurry pixels on low res devices.
I think it is better if we slightly increase the size of the plus so we are on rounded pixels. But we need to "blunting" the point a bit.
We need to change this as wel in the bookmark icon.
Left is yours, new one on the right.
icons/bookmark-add.svg
Outdated
| <path d="M19 21l-7-5-7 5V5a2 2 0 012-2h10a2 2 0 012 2z" /> | ||
| <line x1="12" x2="12" y1="7" y2="12" /> | ||
| <line x1="14.5" x2="9.5" y1="9.5" y2="9.5" /> |
There was a problem hiding this comment.
| <path d="M19 21l-7-5-7 5V5a2 2 0 012-2h10a2 2 0 012 2z" /> | |
| <line x1="12" x2="12" y1="7" y2="12" /> | |
| <line x1="14.5" x2="9.5" y1="9.5" y2="9.5" /> | |
| <path d="m19 21-7-4-7 4V5a2 2 0 0 1 2-2h10a2 2 0 0 1 2 2v16Z"/> | |
| <line x1="12" x2="12" y1="7" y2="13" /> | |
| <line x1="15" x2="9" y1="10" y2="10" /> |
There was a problem hiding this comment.
Well actually I copied from the bookmark icon and just added the plus icon. Do I need to change the bookmark too?
There was a problem hiding this comment.
Yes if you can do 😃, that would be great.
And maybe you can add a bookmark-minus as wel.
Signed-off-by: Sri Aspari <[email protected]>
Signed-off-by: Sri Aspari <[email protected]>
icons/bookmark.svg
Outdated
| @@ -9,5 +9,5 @@ | |||
| stroke-linecap="round" | |||
| stroke-linejoin="round" | |||
| > | |||
| <path d="M19 21l-7-5-7 5V5a2 2 0 012-2h10a2 2 0 012 2z" /> | |||
| <path d="m19 21-7-4-7 4V5a2 2 0 0 1 2-2h10a2 2 0 0 1 2 2v16Z"/> | |||
There was a problem hiding this comment.
| <path d="m19 21-7-4-7 4V5a2 2 0 0 1 2-2h10a2 2 0 0 1 2 2v16Z"/> | |
| <path d="m19 21-7-4-7 4V5a2 2 0 0 1 2-2h10a2 2 0 0 1 2 2v16Z" /> |
icons/bookmark-minus.svg
Outdated
| <path d="m19 21-7-4-7 4V5a2 2 0 0 1 2-2h10a2 2 0 0 1 2 2v16Z"/> | ||
| <line x1="15" x2="9" y1="10" y2="10"/> |
There was a problem hiding this comment.
| <path d="m19 21-7-4-7 4V5a2 2 0 0 1 2-2h10a2 2 0 0 1 2 2v16Z"/> | |
| <line x1="15" x2="9" y1="10" y2="10"/> | |
| <path d="m19 21-7-4-7 4V5a2 2 0 0 1 2-2h10a2 2 0 0 1 2 2v16Z" /> | |
| <line x1="15" x2="9" y1="10" y2="10" /> |
icons/bookmark-plus.svg
Outdated
| <path d="m19 21-7-4-7 4V5a2 2 0 0 1 2-2h10a2 2 0 0 1 2 2v16Z"/> | ||
| <line x1="12" x2="12" y1="7" y2="13"/> | ||
| <line x1="15" x2="9" y1="10" y2="10"/> |
There was a problem hiding this comment.
| <path d="m19 21-7-4-7 4V5a2 2 0 0 1 2-2h10a2 2 0 0 1 2 2v16Z"/> | |
| <line x1="12" x2="12" y1="7" y2="13"/> | |
| <line x1="15" x2="9" y1="10" y2="10"/> | |
| <path d="m19 21-7-4-7 4V5a2 2 0 0 1 2-2h10a2 2 0 0 1 2 2v16Z" /> | |
| <line x1="12" x2="12" y1="7" y2="13" /> | |
| <line x1="15" x2="9" y1="10" y2="10" /> |
There was a problem hiding this comment.
@siarie Awesome great work. One last small code style thingy.
|
@siarie Great work, thanks for the new icons! |
|
You're welcome... 😄 |
Preview
100%
