Skip to content

Commit

Permalink
Do not disable static_link_cpp_runtimes when toolchain.supportsEmbed…
Browse files Browse the repository at this point in the history
…dedRuntimes is not set

    Before, Bazel explicitly added static_link_cpp_runtimes to disabled features, when toolchain didn't set supportsEmbeddedRuntimes. This is unnecessary (if the toolchain doesn't support embeddded runtimes, it can just not create/enable the feature), and it makes migration for bazelbuild/bazel#5883 harder. Let's remove it.

    bazelbuild/bazel#5883
    bazelbuild/bazel#6861

    RELNOTES: None.
    PiperOrigin-RevId: 229188252
  • Loading branch information
Luca Di Grazia committed Sep 4, 2022
1 parent 1e14ee3 commit e2169ca
Showing 1 changed file with 0 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -912,12 +912,6 @@ public static FeatureConfiguration configureFeaturesOrThrowEvalException(
}
if (branchFdoProvider.isAutoXBinaryFdo()) {
allFeatures.add(CppRuleClasses.XBINARYFDO);
// For LLVM, support implicit enabling of ThinLTO for XFDO unless it has been
// explicitly disabled.
if (toolchain.isLLVMCompiler()
&& !allUnsupportedFeatures.contains(CppRuleClasses.THIN_LTO)) {
allFeatures.add(CppRuleClasses.ENABLE_XFDO_THINLTO);
}
}
}
if (cppConfiguration.getFdoPrefetchHintsLabel() != null) {
Expand Down

0 comments on commit e2169ca

Please sign in to comment.