Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarking workflows/scripts #1

Merged
merged 3 commits into from
May 7, 2022

Conversation

paradust7
Copy link
Contributor

  • track_minetest workflow: Periodically updates the minetest/irrlicht revision numbers. (pushes back into this repo)
  • perf: Builds and runs the benchmarks on every push.

Copy link
Contributor

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how this works

@sfan5 sfan5 merged commit 3befbfa into luanti-org:master May 7, 2022
@sfan5
Copy link
Contributor

sfan5 commented May 8, 2022

For some reason the automated commits do not actually trigger workflow runs?!

@paradust7
Copy link
Contributor Author

I thought I had tested this, but apparently not:

https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow

To prevent infinite recursion, workflows can't be triggered by commits using a GITHUB_TOKEN belonging to another workflow.
They suggest using a personal API token. I was hoping to avoid this, because it appears there's no way to limit access to a single repo. An API token for a given user would be able to commit to all repos the user has access to. I suppose it would be possible to create a dummy user that only has commit access to that one repo, and then generate a personal API token from that. But that's a lot of extra work that can't be simply written into the workflow yml.

Let me try to combine the two workflows, so that the cron job itself will do the build.

@sfan5
Copy link
Contributor

sfan5 commented May 8, 2022

This should work though? https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow
(unless that requires a personal token for the same reasons)

@paradust7
Copy link
Contributor Author

paradust7 commented May 8, 2022

Unfortunately it appears that API endpoint is not accessible either except through a personal token.

As an quick fix, I've just combined the two workflows, so that the build, benchmark, and publish will happen every 3 hours, or every manual push: #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants