Fix password check ldap #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- does not use $entry that is a global pointing to irrelevant data - set message using language only if keyword exists ( avoid null ) else keep keyword ( works for empty "" == success value too ) - if newpassword is missing return newpasswordrequired keyword - 'result' is always set to a keywork, empty means success: can be parsed programatically independently of language - 'message' is intented for human display.
- ex
$pwd_forbidden_ldap_fields = array('sn');
if provided entry to check does not have sn attribute, no error will be traced
no check will occur since there is no attribute to compare with
- this allow to pass $entry_array = array() and have no error
if no check for ldap attribute is expected by calling function.
coudot
reviewed
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.