-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SMS code won't send when captcha is enabled #720
Comments
May be linked to fix on PHP session management. We need to reproduce and search a solution |
I reproduce. Should come from #680 |
working on |
sendsms.php is called multiple times and the second time (smsuserfound) it is called captcha is not displayed but captcha check is done again. |
- revert to previous behavior of sendsms to place captcha check. - sendsms is called mutliple times during sms sending process one the first need captcha check. - was a regression of ltb-project#680
did kept in sendsms same checking place than before #680 but keep new generic function. fix regression and keep feature. |
@matazar Thanks for the report ! I have to appologize, since i am responsible of this regression. |
@artlog It's no problem, thank you for addressing it so quickly! |
After upgrading to version 1.5.1, I've found I can't reset the password using the SMS method when the captcha is enabled.
With the captcha enabled, when you press send on the "Check that user information are correct and press Send to get SMS token" page, it redirects you back to the original SMS page claiming "the captcha is required" with no code sent.
When the captcha is disabled, the code is sent and the user is redirected to the SMS token page after clicking send as expected.
No errors are written to the logs file when this happens.
This is on FreeBSD using nginx with the sms_method set to mail. Tested with both PHP74 and PHP80.
The text was updated successfully, but these errors were encountered: