DM-49155: Turn on illumination corrections for LSSTComCam. #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yalsayyad
approved these changes
Feb 27, 2025
| @@ -31,3 +31,5 @@ | |||
| config.select.maxPsfTraceRadiusDelta = 4.4 | |||
| config.select.maxPsfApFluxDelta = 1.6 | |||
| config.select.maxPsfApCorrSigmaScaledDelta = 0.13 | |||
|
|
|||
| config.doApplyFlatBackgroundRatio = True | |||
There was a problem hiding this comment.
Does this config parameter exist in makeWarp? And did you do your Jenkins run before Arun merged the update? This might need some surgery.
There was a problem hiding this comment.
This is just applied to makeDirectWarp.py, and this was committed after Arun merged his update. I don't know why there would be a makeWarp.py anyway.
Meanwhile, if this isn't set correctly then the pipeline contracts would fail in drp_pipe because it has to be consistent with the other obs_lsst illumination correction overrides.
erykoff
force-pushed
the
tickets/DM-49155
branch
from
8189197 to
9cace36
Compare
erykoff
force-pushed
the
tickets/DM-49155
branch
from
9cace36 to
f3afeda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.