DM-49166: Add ComCam overrides for make(PsfMatched|Direct)Warp #608
Conversation
| config.select.maxScaledSizeScatter = 0.014 | ||
| config.select.maxPsfTraceRadiusDelta = 0.091 | ||
| config.select.maxPsfApFluxDelta = 0.047 | ||
| config.select.maxPsfApCorrSigmaScaledDelta = 0.041 |
There was a problem hiding this comment.
Are these duplicated with the makeWarp configs for this instrument, then, rather than shared as you did for comCam?
There was a problem hiding this comment.
I'm a bit conflicted about loading the configs of one task to another, since there are configs that don't match up and depending on what overrides end up where, it could break things. Given the current overrides and pending deprecation, it's not an issue now and can homogenize it either way.
config/comCam/makeWarp.py
Outdated
| # DM-47171: 9.0 (1.8 arcsec) corresponds to the ~98.5% percentile of the | ||
| # PSF FWHM distribution in the 2nd and 3rd weeks of ComCam science observations | ||
| # selectDeepCoaddVisits is currently set the the default 2.0 arcsec | ||
| # makePsfMatchedWarp configs cannot be loaded in the same way in general. |
There was a problem hiding this comment.
This vague inline comment doesn't really add much information. Is the reason that you PLAN to add makePsfMatchedWarp-specific overrides to the obs_lsst/config/comCam/makePsfMatchedWarp.py one day? If you think that's more likely than this value getting changed, then say something like:
# keep this in sync with config.modelPsf.defaultFwhm in makePsfMatchedWarp.py
and you might as well leave in the 3 line explanation of what 9.0 is in that case too.
Also my fault because I'm the one who changed it, but as of December, the 3rd line lies: selectDeepCoaddVisits is currently set to 1.7 arcsec.
There was a problem hiding this comment.
No, the reason is if someone added a line like config.warpAndPsfMatch.psfMatch.kernel["AL"].kernelSize = 29, loading that here would result in an error. Given that the classes don't obey an inheritance relationship, it would not be a good idea to load makePsfMatchedWarp config file into makeWarp. I will go ahead with the comment about keeping this in sync.
arunkannawadi
force-pushed
the
tickets/DM-49166
branch
2 times, most recently
from
0b11e60 to
465ee50
Compare
arunkannawadi
force-pushed
the
tickets/DM-49166
branch
from
465ee50 to
596aae8
Compare
No description provided.