Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-48887: Enable zeroth order interp if not enough stars. #603

Merged
merged 1 commit into from
Feb 17, 2025
Merged

DM-48887: Enable zeroth order interp if not enough stars. #603

merged 1 commit into from
Feb 17, 2025

Conversation

PFLeget
Copy link
Contributor

@PFLeget PFLeget commented Feb 14, 2025

erykoff
erykoff approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but I think it could be made the overall default making this unnecessary. (See other PR comments)

@PFLeget
Copy link
Contributor Author

PFLeget commented Feb 14, 2025

I guess for the moment as commented in the other PR, I would like to have it as optional until I make something more clean and tractable.

@PFLeget PFLeget merged commit e1eda53 into main Feb 17, 2025
3 checks passed
@PFLeget PFLeget deleted the tickets/DM-48887 branch February 17, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erykoff erykoff erykoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PFLeget @erykoff