DM-48174: Update ComCam manual defect script and add new manual defects #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
force-pushed
the
tickets/DM-48174
branch
6 times, most recently
from
361a5cb to
080c5dc
Compare
erykoff
force-pushed
the
tickets/DM-48174
branch
2 times, most recently
from
46cf420 to
1270137
Compare
erykoff
changed the title
erykoff
force-pushed
the
tickets/DM-48174
branch
from
f2346f5 to
f4bd3d7
Compare
czwa
approved these changes
Jan 29, 2025
| (680, 2000, 11, 966), | ||
| ), | ||
| ) | ||
| if det.getId() == 1: |
There was a problem hiding this comment.
As noted in the discussions earlier, this could/should be an elif. Maybe it'd be better as a match/case block, but I have no strong opinions about whether that's faster or more legible, so I mention it only for completeness.
erykoff
force-pushed
the
tickets/DM-48174
branch
from
f4bd3d7 to
160e4d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.