DM-47365: new manual defects for LSSTComCam #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aferte
force-pushed
the
tickets/DM-47365
branch
2 times, most recently
from
b63a25e to
a9e436b
Compare
czwa
approved these changes
Dec 5, 2024
|
|
||
| # This is only valid for LSSTComCam which has a single raft | ||
| manual_defects = \ | ||
| Defects.readText('obs_lsst_data/comCam/manual_defects/r22_s'+detName[5:]+'/20241120T000000.ecsv') |
There was a problem hiding this comment.
This may be redundant with the changes in obs_base that make these curated calibrations that are ingested into the butler with butler write-curated-calibrations. The files are small, and doing it this way means we can generate (and regenerate) the defects prior this this merging, so I don't think it's that big of a deal.
However, I think this would be better getting the path dynamically, like we do in other scripts like this (https://github.com/lsst/obs_lsst/blob/main/python/lsst/obs/lsst/script/write_latiss_crosstalk_coeffs.py#L42 for reference). getPackageDir and os.join make it safer to construct paths like this, as it will use whichever obs_lsst_data source is set up.
aferte
force-pushed
the
tickets/DM-47365
branch
from
a9e436b to
8b20677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.