DM-47034: Convert effTime fiducials to electrons #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins run #2869 |
mfisherlevine
approved these changes
Oct 22, 2024
ebellm
changed the title
…o be in electrons
kadrlica
force-pushed
the
tickets/DM-47034
branch
from
2020b82 to
5b3bafd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ComCam, ComCamSim and lsstCam will produce images in units of electrons. This means that the sky background and zeropoint values should be updated to be in units of electrons. This is actually the native unit of SMTN-002, so in many ways this is cleaner than what was being done before (which involved estimating and applying the gain).