Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge PR#305 and PR#306 (fix generateDonutDirectDetect) #311

Merged
merged 20 commits into from
Feb 5, 2025
Merged

Merge PR#305 and PR#306 (fix generateDonutDirectDetect) #311

merged 20 commits into from
Feb 5, 2025

Conversation

suberlak
Copy link
Contributor

@suberlak suberlak commented Feb 4, 2025

No description provided.

mfisherlevine and others added 20 commits January 14, 2025 08:12
@mfisherlevine
Declare isr in pipeline before referencing it
d328a1c
@jbkalmbach
Use ISR configs from comcam commissioning as default
fdb2e58
@mfisherlevine
Add tests for production pipelines
a6cf674
@mfisherlevine
Add aggregateDonutTablesTask to donutVizGroupPipeline definition
39c23d2
@mfisherlevine
Update .gitignore for new packaging system
492f997
@jbkalmbach
Fix ComCamSim pipeline.
c281c8f
@mfisherlevine
Merge pull request #305 from lsst-ts/tickets/DM-48416
f010226 
DM-48416: Declare isr in pipeline before referencing it
@suberlak
fix behavior for no sources selected in generateDonutDirectDetectTask
86f02e8
@suberlak
add test for null selection in generateDonutDirectDetectTask
d126551
@suberlak
update version history
649fbe2
@suberlak
run black on generateDonutDirectDetectTask
464acfd
@suberlak
run black on test_generateDonutDirectDetectTask
357a865
@suberlak
fix updateDonutCatalog when selection is off in generateDonutDirectDe…
0770a9b 
…tectTask
@suberlak
test for correct behavior without donut selection in generateDonutDirect
d53fda6
@suberlak
fix typo in generateDonutDirectDetectTask
d1b9353
@suberlak
safeguard cutOutDonutsBase against case of no blend data
58b1696
@suberlak
run black on cutOutDonutsBase
9092c90
@suberlak
set placeholder blend_centroid in generateDonutDirectDetect
25aaa96
@suberlak
set placeholder for blendCentroid in cutOutDonutsBase
584f2d8
@suberlak
Merge pull request #306 from lsst-ts/tickets/DM-44529
5318dd6 
Tickets/DM-44529: fix generateDonutDirectDetect for null selection
@suberlak suberlak changed the title Merge PR#306 (fix generateDonutDirectDetect) Merge PR#305 and PR#306 (fix generateDonutDirectDetect) Feb 4, 2025
@suberlak suberlak requested a review from jbkalmbach February 4, 2025 23:17
jbkalmbach
jbkalmbach approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@jbkalmbach jbkalmbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suberlak suberlak merged commit 0b1800d into main Feb 5, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbkalmbach jbkalmbach jbkalmbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suberlak @jbkalmbach @mfisherlevine