Add new redirect app to provide a url shortener feature
#228
Conversation
|
Well not necessary redirect only, but this view is for M1M3ForceActuator data - so something on this tune. Thanks |
sebastian-aranda
force-pushed
the
tickets/DM-42373
branch
from
599e205 to
e302f76
Compare
manager/redirect/tests.py
Outdated
| Returns | ||
| ------- | ||
| int | ||
| The random force actuator |
There was a problem hiding this comment.
Better: The random force actuator record. Also, data type isn't int, but ForceActuatorData from lsst.ts.xml.tables.m1m3.
| return fa.get_index(index_type) | ||
|
|
||
|
|
||
| class CHRONOGRAF_SITES: |
There was a problem hiding this comment.
Could that be turned into enum? Like:
class CHRONOGRAF_SITES(enum.IntEnum):
SUMMIT = 1
USDF = 2
etc..?
see https://github.com/lsst-ts/ts_xml/blob/develop/python/lsst/ts/xml/enums/MTM1M3.py for ane example.
There was a problem hiding this comment.
I'm a bit hesitant of doing this change. Having the class with a str hash gives me easier handling of the view as the site param is set as a str in the url (and then it is used on utils functions that needs the site param as a string), e.g:
get_site_url_domain("summit")Whereas summit can be usdf, base or tucson (added in case of future extensions). If I make the change to an enumeration, I'll need to create another hash class to make the conversion from the site in string to an enum.
There was a problem hiding this comment.
As discussed internally with @pkubanek , an StrEnum would be handy here, although we need to update to python > 3.11. A TODO was added for this.
…vice First view created for m1m3 bump tests chronograf dashboards
sebastian-aranda
force-pushed
the
tickets/DM-42373
branch
from
e302f76 to
ab47e0d
Compare
This PR adds a new
redirectapp to provide something like an url shortener feature, for easier link manipulation and sharing.