Extend LOVE manager routing system for subpath app serving #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-aranda
changed the title
sebastian-aranda
changed the title
sebastian-aranda
force-pushed
the
tickets/DM-39986
branch
from
228d2bd to
20aaf7f
Compare
mareuter
approved these changes
Jul 17, 2023
README.md
Outdated
| @@ -40,6 +40,7 @@ All these variables are initialized with default variables defined in :code:`.en | |||
| - `LOVE_SITE`: defines the site name of the LOVE system. This value is used to identify the LOVE system in the LOVE-manager. | |||
| - `REMOTE_STORAGE`: defines if remote storage is used. If this variable is defined, then the LOVE-manager will connect to the LFA to upload files. If not defined, then the LOVE-manager will store the files locally. | |||
| - `COMMANDING_PERMISSION_TYPE`: defines the type of permission to use for commanding. Currently two options are available: `user` and `location`. If `user` is used, then requests from users with `api.command.execute_command` permission are allowed. If `location` is used, then only requests from the configured location of control will be allowed. If not defined, then `user` will be used. | |||
| - `URL_SUBPATH`: defines the path where the LOVE-manager will be served. If not defined, then requests will be served from the root path `/`. Note: the application has its own routing system, so this variable must be thought as a prefix to the application's routes. | |||
There was a problem hiding this comment.
thought as a to though of as a
There was a problem hiding this comment.
thought of as as right?
There was a problem hiding this comment.
thought of as a prefix ...
| @@ -17,6 +17,10 @@ | |||
| # Quick-start development settings - unsuitable for production | |||
| # See https://docs.djangoproject.com/en/2.2/howto/deployment/checklist/ | |||
|
|
|||
| # Define the URL subpath for this application when deployed: | |||
| FORCE_SCRIPT_NAME = os.environ.get("URL_SUBPATH") | |||
There was a problem hiding this comment.
You could set the default value here as "" so that the if FORCE_SCRIPT_NAME checks become unnecessary.
There was a problem hiding this comment.
I wanted to do that in a beginning, but then I realized this is a Django setting variable, thus it is thought to be None if no string is defined. I did't try this out, but I think if set "" as default value, some things could stop working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the routing system of the LOVE-manager in order to allow serving the app from a sub path (e.g. /love).