Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Dockerfile for only serving static files #112

Merged
merged 3 commits into from
Apr 21, 2021

Conversation

sebastian-aranda
Copy link
Contributor

This PR add a new Dockerfile for serving LOVE-manager static files. The folders with static files are:

  • /usr/usr/love/manager/static
  • usr/src/love/manager/media

Now the image doesn't run the server, collect static files and only mounts the related volumes.

Copy link
Contributor

@mareuter mareuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would go one extra step like the frontend does to create a new container that copies out the static files from the build container. That way the static container is smaller and only contains what we need.

@mareuter mareuter self-requested a review April 21, 2021 21:34
Copy link
Contributor

@mareuter mareuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that will do nicely. Thanks for making this happen.

@sebastian-aranda sebastian-aranda merged commit 9284e47 into develop Apr 21, 2021
@sebastian-aranda sebastian-aranda deleted the tickets/LOVE-38 branch April 29, 2021 14:04
@areyesd14 areyesd14 mentioned this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants