Last fixes after rebase

manager/api/tests/test_lfa.py

@@ -3,7 +3,7 @@
 from django.http import HttpRequest
 from django.test import TestCase, override_settings
 from django.utils.datastructures import MultiValueDict
-from api.views import lfa
+from manager.utils import upload_to_lfa
 
 
 @override_settings(DEBUG=True)
@@ -17,7 +17,7 @@ def setUp(self):
     def test_no_files_uploaded(self, mock_post):
         request = HttpRequest()
         request.FILES = MultiValueDict()
-        response = lfa(request, option="upload-file")
+        response = upload_to_lfa(request, option="upload-file")
         self.assertEqual(response.status_code, 400)
         self.assertEqual(response.data, {"ack": "No files to upload"})
 
@@ -30,7 +30,7 @@ def test_successful_file_upload(self, mock_post):
 
         request = HttpRequest()
         request.FILES["file[]"] = [SimpleUploadedFile("test.txt", b"file_content")]
-        response = lfa(request, option="upload-file")
+        response = upload_to_lfa(request, option="upload-file")
         self.assertEqual(response.status_code, 200)
         self.assertEqual(
             response.data,
@@ -61,7 +61,7 @@ def test_successful_multiple_file_upload(self, mock_post):
         uploaded_file2 = SimpleUploadedFile("test2.txt", b"file_content_2")
         request.FILES = MultiValueDict({"file[]": [uploaded_file1, uploaded_file2]})
 
-        response = lfa(request, option="upload-file")
+        response = upload_to_lfa(request, option="upload-file")
 
         self.assertEqual(response.status_code, 200)
         self.assertEqual(
@@ -83,13 +83,13 @@ def test_failed_file_upload(self, mock_post):
 
         request = HttpRequest()
         request.FILES["file[]"] = [SimpleUploadedFile("test.txt", b"file_content")]
-        response = lfa(request, option="upload-file")
+        response = upload_to_lfa(request, option="upload-file")
         self.assertEqual(response.status_code, 400)
         self.assertEqual(response.data, {"ack": "Error when uploading files"})
 
     def test_invalid_option(self):
         request = HttpRequest()
         request.FILES["file[]"] = [SimpleUploadedFile("test.txt", b"file_content")]
-        response = lfa(request, option="invalid-option")
+        response = upload_to_lfa(request, option="invalid-option")
         self.assertEqual(response.status_code, 400)
         self.assertEqual(response.data, {"ack": "Option not found"})

manager/manager/utils.py

@@ -155,6 +155,7 @@ def url(self, name):
             return name
         return f"{settings.MEDIA_URL}{name}"
 
+
 def upload_to_lfa(request, *args, **kwargs):
     """Connects to LFA API to upload a new file
 
@@ -197,6 +198,7 @@ def upload_to_lfa(request, *args, **kwargs):
 
     return Response({"ack": "Option not found"}, status=400)
 
+
 def get_jira_title(request_data):
     """Generate title for a jira ticket
 
@@ -356,11 +358,7 @@ def jira_ticket(request_data):
     if "request_type" not in request_data:
         return Response({"ack": "Error reading request type"}, status=400)
 
-    tags_data = (
-        request_data.get("tags").split(",")
-        if request_data.get("tags") != 'undefined'
-        else []
-    )
+    tags_data = request_data.get("tags").split(",") if request_data.get("tags") else []
 
     try:
         jira_payload = {
@@ -409,6 +407,7 @@ def jira_ticket(request_data):
         status=400,
     )
 
+
 def jira_comment(request_data):
     """Connects to JIRA API to add a comment to a previously created ticket on a specific project.
     For more information on issuetypes refer to:
@@ -462,6 +461,7 @@ def jira_comment(request_data):
         status=400,
     )
 
+
 def get_client_ip(request):
     """Return the client IP address.