Add Location Control sources of information #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onent Add global state for control location info
areyesd14
reviewed
Apr 11, 2023
areyesd14
reviewed
Apr 11, 2023
| <Value>UNKNOWN</Value> | ||
| <Label>Obsv. Mode</Label> | ||
| <Value>{this.props.simonyiObservingMode}</Value> | ||
| <Value>Unknown</Value> |
There was a problem hiding this comment.
This "Unknown" value is correct?
There was a problem hiding this comment.
We still don't have the source of information for the Operation Mode, we are investigating where to get it. For the moment I think is ok to keep it like "Unknown"
areyesd14
reviewed
Apr 11, 2023
| <Label>Power Source</Label> | ||
| <Value>UNKNOWN</Value> | ||
| <Value>Unknown</Value> |
There was a problem hiding this comment.
This "Unknown" value is correct?
There was a problem hiding this comment.
Same as the previous comment, we still don't have this source of information.
areyesd14
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Looks good! Thanks @sebastian-aranda !!
I left a few single comments about some "Unknown" values, but I think this is because we haven't yet this information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR connects the
ControlLocationmodel (lsst-ts/LOVE-manager#179) to get the current set location of control. Also some refactor was done to theObservatorySummaryandObservatorySummaryMenucomponents. Some missing telemetries were also added.