DM-44763: Stop using db_session_dependency in UWS #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db_session_dependency provided by Safir is by definition a singleton. Previously, the UWS layer used it to talk to the UWS database, but a service using the UWS layer may want its own database connection for other purposes and the UWS layer was monopolizing it. Fix this by creating a separate database engine and session inside the UWS layer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
db_session_dependency provided by Safir is by definition a singleton. Previously, the UWS layer used it to talk to the UWS database, but a service using the UWS layer may want its own database connection for other purposes and the UWS layer was monopolizing it. Fix this by creating a separate database engine and session inside the UWS layer.