DM-48924: CLI command for migrating the HTML cache keys to the new format #95
+350
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathansick
force-pushed
the
tickets/DM-48924-cache-migration
branch
3 times, most recently
from
07d452c to
548d276
Compare
This CLI command can migrate the NbHtmlCache keys from the old format (based on a b64 encoding of a JSON object with the parameter values and display settings) to the new format computed more reliably from the URL query string. This command can run in a dry-run mode and can also work on either a specific page, or with all pages.
This was tricky to set up because I wanted to test it at the service level, but we don't have a useful factory for creating services outside the app context yet.
Some of the early pages in Times Square on data dev have invalid parameters --- skip over those.
jonathansick
force-pushed
the
tickets/DM-48924-cache-migration
branch
from
904a632 to
f5f40ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CLI command can migrate the NbHtmlCache keys from the old format (based on a base64 encoding of a JSON object with the parameter values and display settings) to the new format computed more reliably from the URL query string.
This command can run in a dry-run mode and can also work on either a specific page, or with all pages.
We'lll run this command via a Kubernetes job.