Bump cadc dependency versions & switch to using cadc-tomcat image #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR bumps up the versions of the cadc dependencies to newer releases. The versions are derived from trying a Gradle build with an open-ended max release version, and using what I got from that which seems to get the latest stable version of each library. I also modified the Dockerfile to use a cadc-tomcat base image instead of the default tomcat. This was a result of a combination of trial & error, reading between the lines and trying to understand what has been done in the dal-siav2 app, as well as how the opencadc repo seems to work. More specifically, I think the cadc-tap image does a few things behind the scenes, like mounting /config to /usr/share/tomcat/config and some other things, and generally seems to be the approach I've seen from some other apps in the opencadc org.
How was this tested:
Manually ran through some standard TAP workflows on idfdev:
There were some related changes that need to be applied to phalanx so that the right params are passed in, so this was tested these changes on a phalanx branch & pointing to an image of tap-postgres from my own Dockerhub repo.
Other considerations:
I don't know if all those dependencies are needed, I got those from checking what was in the libs of the tomcat app once built with gradle.
This version will not work with the version of phalanx as it is in the most recent version on main: 3e88df64a1bfb59f84d2a58a9cc0f4e8f91ecb0c
Specifically, the main aspect that breaks is the Authentication layer, which requires moving from Authenticator to an IdentityManager, as well as defining and passing in new cadc-registry.properties & catalina.properties files which among other things includes a mapping for the authentication we are using, i.e.: