DM-43461: Enable background page recomputation in Times Square #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 72dd989 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jonathansick
added a commit
to lsst-sqre/phalanx
that referenced
this pull request
Mar 27, 2024
This update affects the Times Square UI and adds a "recalculate" button. lsst-sqre/squareone#163
jonathansick
force-pushed
the
tickets/DM-43461
branch
from
2edd58a to
37aab13
Compare
This context and provider lets us wrap up the concerns around taking URL path and query parameters and breaking those down into the Times Square API URL, notebook parameters, and display settings. This dramatically simplifies the page components and lets us reuse code between the regular and github-pr pages. It also lets us avoid prop drilling to pass this info to the several components that consume this info. Additionally, the Times Square hooks, like useTimesSquarePage and useHtmlStatus use this context so that, again, individual pages don't need to pass additional arguments based on the URL parameters.
This solves the problem of the parameters form being blank when navigating back to a page.
jonathansick
force-pushed
the
tickets/DM-43461
branch
from
686aa96 to
0db4ff6
Compare
This package provides a client for server-sent events with a fetch-like API.
This new field is available in Times Square API 0.11.0. Its the URL of the html/events server-sent events endpoint.
jonathansick
force-pushed
the
tickets/DM-43461
branch
from
9fb6f48 to
748e127
Compare
This context provider has a useEffect hook that uses fetch-event-source to get the server-sent event from the Times Square /pages/:page/html/events endpoint. Components can use this context to get real-time updates on the HTML for a page instance and the status of the rendering.
jonathansick
force-pushed
the
tickets/DM-43461
branch
from
748e127 to
eb3b403
Compare
This may help with the storybook issue for squared and the GafaelfawrUserMenu. storybookjs/storybook#24194
This should make it clearer what the reset button does. We really want a "lighter" or "darker" version of the red here; but let's try just manipulating opacity for now.
jonathansick
force-pushed
the
tickets/DM-43461
branch
from
1a6fc4a to
b1b7c4a
Compare
jonathansick
force-pushed
the
tickets/DM-43461
branch
from
b1b7c4a to
66fe54a
Compare
This shows the execution status, including the age of the execution and execution duration if available. It's also where we put the button to request a recomputation of an existing page. The component's data is populated by the TimesSquareHtmlEventsContext. We show how to mock the context in Storybook to design different states.
jonathansick
force-pushed
the
tickets/DM-43461
branch
from
5c6ba22 to
f4277a0
Compare
Merged
jonathansick
added a commit
to lsst-sqre/phalanx
that referenced
this pull request
Apr 11, 2024
This update affects the Times Square UI and adds a "recalculate" button. lsst-sqre/squareone#163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimesSquareParametersProvider. This context and provider lets us wrap up the concerns around taking URL path and query parameters and breaking those down into the Times Square API URL, notebook parameters, and display settings. This dramatically simplifies the page components and lets us reuse code between the regular and github-pr pages. It also lets us avoid prop drilling to pass this info to the several components that consume this info.TimesSquareHtmlEventsProvider. This context and provider gives access to the Times Square/v1/pages/:page/html/events?{param}server-sent events endpoint.DELETE /v1/pages/:page/html?{param}request.