DM-48977: Switch to new Python type variable syntax #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to the new Python syntax for generic parameters to classes and functions. This apparently unconfused mypy and Ruff enough that it uncovered some additional diagnostics, which required some `noqa` comments and some code refactoring, one to fix a bug and another to unconfuse the type checker.
fajpunk
reviewed
Feb 18, 2025
| @@ -114,21 +111,21 @@ def __init__( | |||
|
|
|||
| # Methods that should be overridden by child classes if needed. | |||
|
|
|||
| async def startup(self) -> None: | |||
| async def startup(self) -> None: # noqa: B027 | |||
There was a problem hiding this comment.
What about return None for these instead of disabling linting? That is, if that gets rid of the warning which I don't actually know if it does...
There was a problem hiding this comment.
Oh, good call, I will try that and see if that suppresses the Ruff warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to the new Python syntax for generic parameters to classes and functions. This apparently unconfused mypy and Ruff enough that it uncovered some additional diagnostics, which required some
noqacomments and some code refactoring, one to fix a bug and another to unconfuse the type checker.