DM-48941: Only check out notebook repos once #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fajpunk
force-pushed
the
tickets/DM-48941
branch
3 times, most recently
from
5d1fc5e to
266f762
Compare
fajpunk
commented
Feb 17, 2025
fajpunk
force-pushed
the
tickets/DM-48941
branch
4 times, most recently
from
baffea4 to
f4b94dc
Compare
rra
approved these changes
Feb 18, 2025
fajpunk
force-pushed
the
tickets/DM-48941
branch
2 times, most recently
from
f322957 to
9e9d29e
Compare
fajpunk
force-pushed
the
tickets/DM-48941
branch
from
fe9aaea to
214fb8f
Compare
rra
approved these changes
Feb 18, 2025
fajpunk
force-pushed
the
tickets/DM-48941
branch
from
214fb8f to
1652475
Compare
Add a reference-counting process-global notebook repo cache. Use this in the NotebookRunner business to only clone notebook repos once per process, not once per monkey.
fajpunk
force-pushed
the
tickets/DM-48941
branch
from
b0e2986 to
6729a14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a process-global notebook repo cache. Use this in the NotebookRunner business to only clone notebook repos once per process, not once per monkey.
The notebook repo refresh functionality complicates this a bit, see this comment