Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-48697: No autostart concurrency limit #397

Merged
merged 1 commit into from
Jan 31, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Other changes

- Remove the limit from the autostart `aiojobs` `Scheduler`. Attempts to start a job past the limit resulted in jobs silently never starting. There are no cases where we would want to limit the autostart concurrency, so a limit is not needed.
2 changes: 1 addition & 1 deletion src/mobu/services/manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def __init__(
self._events = events
self._logger = logger
self._flocks: dict[str, Flock] = {}
self._scheduler = Scheduler(limit=1000, pending_limit=0)
self._scheduler = Scheduler(limit=None, pending_limit=0)

async def aclose(self) -> None:
"""Stop all flocks and free all resources."""
Expand Down